Scaled Creating Polls dialog box for small windows

[ankur12-1610]

Signed-off-by: ankur12-1610 [email protected]

Fixes: vector-in/element-web/#21855

polls.mp4

---

Here's what your changelog entry will look like:

🐛 Bug Fixes

• Scaled Creating Polls dialog box for small windows (#8530). Contributed by @ankur12-1610.

[ankur12-1610]

@t3chguy can you give a look at it? 😅

[SimonBrandner]

I think this would result in ^ (double scrollabars)

[ankur12-1610]

I think this would result in ^ (double scrollabars)

@SimonBrandner but I haven't changed anything related to scrollbars I've just played with footer of the dialog 🤔
And ig current element version has the same dialog box? or am I wrong?

[SimonBrandner]

Then I am unsure as to how this PR improves the situation - the dialog still seems to behave unideally in small windows. What am I missing?

[ankur12-1610]

Then I am unsure as to how this PR improves the situation - the dialog still seems to behave unideally in small windows. What am I missing?

In small windows the footer used to overlap over the content due to its absolute position and also there wasn't any background given to footer so as soon it overlapped the content in small windows the content was visible through the footer.

[SimonBrandner]

Ah, I see - I am not sure if we would accept this as a bugfix for the mentioned issue as this only slightly changes the situation but the dialog still feels very much confusing/unusable

[SimonBrandner]

Do you think you would be able to fix the other issue - mainly the scrolling weirdness?

[ankur12-1610]

Do you think you would be able to fix the other issue - mainly the scrolling weirdness?

Yeah, but I'll need to recreate the dialog from the base cause there are two scrollable divs which are creating a little bit of problem :')

[ankur12-1610]

Ah, I see - I am not sure if we would accept this as a bugfix for the mentioned issue as this only slightly changes the situation but the dialog still feels very much confusing/unusable

Ah! I just saw the issue and gave it a try was not sure end result will be significant or not 😅

[SimonBrandner]

Do you think you would be able to fix the other issue - mainly the scrolling weirdness?

Yeah, but I'll need to recreate the dialog from the base cause there are two scrollable divs which are creating a little bit of problem :')

As long as that is the best way to fix the problem and we retain all the features, that would be ideal :)

[ankur12-1610]

Do you think you would be able to fix the other issue - mainly the scrolling weirdness?

Yeah, but I'll need to recreate the dialog from the base cause there are two scrollable divs which are creating a little bit of problem :')

As long as that is the best way to fix the problem and we retain all the features, that would be ideal :)

Cool, then I'll create a new issue on resolving two scrollbars, is it okay?

[SimonBrandner]

Do you think you would be able to fix the other issue - mainly the scrolling weirdness?

Yeah, but I'll need to recreate the dialog from the base cause there are two scrollable divs which are creating a little bit of problem :')

As long as that is the best way to fix the problem and we retain all the features, that would be ideal :)

Cool, then I'll create a new issue on resolving two scrollbars, is it okay?

Sure, go ahead

[ankur12-1610]

@SimonBrandner I guess the current issue I'm working on is related to the scrolling weirdness, I'll make the changes to this PR itself rather than creating a new issue. Does that work?

[SimonBrandner]

@SimonBrandner I guess the current issue I'm working on is related to the scrolling weirdness, I'll make the changes to this PR itself rather than creating a new issue. Does that work?

Sure!

[gaelledel]

note: We should already have a component for this type of modal on the web
It should all be 100% opaque including the sticky footer

[Johennes]

Since this seems abandoned, I opened #9873.

[turt2live]

Closing in favour of #9873 - thanks for your contribution!