This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add a confirmation when ignoring a user #8620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#14746 Doesn't apply when un-ignoring.
turt2live
added
the
T-Enhancement
|
What's the difference between this and #6116? |
|
me being absolutely blind |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#14746
Doesn't apply when un-ignoring.
I don't believe we have a utility for checking if a dialog opened, and an end-to-end test feels ways overkill on this, so no tests for now. If someone has a pointer to a test which checks for a dialog then happy to write appropriate tests.
Here's what your changelog entry will look like:
✨ Features