This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make Element Call screensharing work on desktop #9476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
added
the
T-Defect
dbkr
approved these changes
Oct 20, 2022
robintown
suggested changes
Oct 20, 2022
|
Doesn't fix the Element Desktop |
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
It does work for me, what version of EC are you using? |
robintown
approved these changes
Oct 20, 2022
Comment on lines
-833
to
-834
| this.messaging!.on(`action:${ElementWidgetActions.TileLayout}`, this.onTileLayout); | ||
| this.messaging!.on(`action:${ElementWidgetActions.SpotlightLayout}`, this.onSpotlightLayout); |
robintown
pushed a commit
to robintown/matrix-react-sdk
that referenced
this pull request
Oct 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires element-hq/element-call#645
Fixes element-hq/element-web#23382
Here's what your changelog entry will look like:
🐛 Bug Fixes