Read receipts improvements for thread view #9595
Conversation
germain-gg
added
the
T-Defect
| </div>, | ||
| reactionsRow, | ||
| msgOption, |
There was a problem hiding this comment.
Some grumbling about code style which I don't particularly expect you to fix: why is this called msgOption when it only contains the read receipts? Also 600 line functions suck.
| </div>, | ||
| reactionsRow, | ||
| msgOption, |
There was a problem hiding this comment.
I note that the non-threads case does:
React.createElement("li", <attrs>,
<>
{ elem }
{ elem }
</>);
whereas this bit does
React.createElement("li", <attrs>,
[
elem,
elem,
]);
Is there a difference? or any reason to prefer one style over the other?
| .mx_EventTile:not(:last-child) { | ||
| .mx_ReadReceiptGroup_noReceipts { | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
could you give this a comment? Evidently it's trying to hide the read receipt group under certain conditions, but I'm failing to grok what those conditions are
| @@ -106,7 +106,7 @@ limitations under the License. | |||
| content-visibility: visible; | |||
| } | |||
|
|
|||
| .mx_EventTile, | |||
| .mx_EventTile[data-layout], | |||
There was a problem hiding this comment.
when is data-layout not present, and what's the rationale for doing this with an attribute selector rather than a class?
| @@ -353,7 +353,7 @@ export default class ThreadView extends React.Component<IProps, IState> { | |||
| ref={this.timelinePanel} | |||
| showReadReceipts={true} | |||
| manageReadReceipts={true} | |||
| manageReadMarkers={true} | |||
| manageReadMarkers={false} | |||
There was a problem hiding this comment.
I was wondering what this actually did, but the comment just says "Enable managing RRs and RMs." Well gee thanks.
What does managing actually entail? and why do we now want to turn it off?
| margin-bottom: 0; | ||
| } | ||
|
|
||
| .mx_EventTile_msgOption { |
There was a problem hiding this comment.
again, is this just used for read receipts? A comment might help if so.
|
Punted to a later stage, this has gone stale and does not match what the design team was interested in. |
Fixes element-hq/element-web#23569
Fixes element-hq/element-web#23576
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes