Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix form tooltip positioning #9598

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Fix form tooltip positioning #9598

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b880c4a
Fix form tooltip positioning
weeman1337 Nov 18, 2022
fa3b2a0
Merge branch 'develop' into weeman1337/fix-form-tooltip-positioning
weeman1337 Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions res/css/views/elements/_Field.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,6 @@ limitations under the License.
}

.mx_Field_tooltip {
margin-top: -12px;
margin-left: 4px;
width: 200px;
}
Comment on lines 176 to 178
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afraid I'm not familiar with this stuff. Where (else) is .mx_Field_tooltip used, why was this necessary in the first place, and why is it no longer necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good questions!

.mx_Field_tooltip is only used for Fields. Means it should not break other places™

I don't know the exact reason for the margin. But it seems like they are not so great aligned when they were introduced.

image


Expand Down
2 changes: 1 addition & 1 deletion res/css/views/elements/_Tooltip.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ limitations under the License.
.mx_Tooltip_chevron {
position: absolute;
left: -7px;
top: 10px;
top: calc(50% - 6px);
width: 0;
height: 0;
border-top: 7px solid transparent;
Expand Down