Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Mark a thread as unread in the threads list due to activity. #9738

Closed
wants to merge 3 commits into from

Conversation

clokep
Copy link
Member

@clokep clokep commented Dec 12, 2022

Follow-on to #9723 to also show the thread as unread in the threads list:

image

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Mark a thread as unread in the threads list due to activity. (#9738).

@clokep
Copy link
Member Author

clokep commented Dec 12, 2022

(Should probably have the same changelog as #9723, but I'm not sure how to do that?)

@clokep clokep added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Dec 12, 2022
@clokep clokep self-assigned this Dec 12, 2022
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me!
Tests are failing, but from what I gather if you get up to date with the upstream develop that should pass. There's nothing that should cause that failure

@clokep
Copy link
Member Author

clokep commented Dec 13, 2022

We'll want to wait to merge this until after the reversion of #9723 lands (see #9745) and we re-land that with fixes.

@clokep
Copy link
Member Author

clokep commented Dec 13, 2022

Going to close this and rebase it on a reworked #9723.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants