This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Allow IndexedDB cleanup operations to fail #9903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox ships with a preference (`dom.indexedDB.privateBrowsing.enabled`) which causes `window.indexedDB` to fail on all requests including `deleteDatabase`. Because of that, Firefox Private Browsing users are left with an infinite loading spinner. `MatrixClient#clearStores` will resolve to a rejected promise if any of its operations fails, which seems correct -- it's unable to complete its tasks. So, to keep from erroring out during initialization, the errors have to be discarded during the lifecycle operations. Signed-off-by: Clark Fischer <[email protected]>
github-actions
bot
added
the
Z-Community-PR
|
This was just fixed in the js-sdk - matrix-org/matrix-js-sdk#3058 |
|
Ah, great, thanks! Guess I was slow to the punch, I checked for issues, but it must've been before everything cropped up. |
|
@clarkf thanks for this! I do want to add some tests to make sure this doesn't regress; if it's ok with you I'll use your new test as a basis. |
|
@richvdh sure thing, however I can help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox ships with a preference (
dom.indexedDB.privateBrowsing.enabled, defaults tofalse) which causeswindow.indexedDBto fail on all requests, includingdeleteDatabase. Because of that, recent builds fail to load entirely in private browsing windows. This can be verified by opening develop.element.io (or any build after matrix-org/matrix-js-sdk@15ef8fa) in a Firefox private browsing window.MatrixClient#clearStoreswill resolve to a rejected promise if any of its operations fails, which seems correct – it's unable to complete its tasks. So, to keep from erroring out during initialization, the errors have to be discarded during the lifecycle operations.Checklist
This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.