This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into langleyd/auto_replace_emoji
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
==========================================
- Coverage 90.19% 90.14% -0.05%
==========================================
Files 179 179
Lines 21468 21627 +159
Branches 280 292 +12
==========================================
+ Hits 19363 19496 +133
- Misses 2102 2128 +26
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jmartinesp
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Rust part LGTM, good job!
florianduros
approved these changes
Jul 9, 2024
…into langleyd/auto_replace_emoji
…into langleyd/auto_replace_emoji
Quality Gate passedIssues Measures |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included this PR?
Custom Suggestion Pattern API and Auto-replace plain text with emoji feature(Web only so far). E.g.
:) => 🙂
What does it look like?
Screen.Recording.2024-07-05.at.14.12.28.mov
Implementation detail
I considered 2 approaches for this:
/
,@
,#
). The advantage of this is that it builds upon an existing pattern rather than creating a new way of doing things. It also gives flexibility to the client as to how the feature works. The version implemented works as the web-client does, by automatically replacing the suggestions, but there has been a suggestion previously that it should work as it does on Telegram where suggestions are rendered first from which the user can choose to accept: