Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "jump to message" functionality #3052

Closed
claell opened this issue Jan 25, 2024 · 5 comments
Closed

Add "jump to message" functionality #3052

claell opened this issue Jan 25, 2024 · 5 comments

Comments

@claell
Copy link

claell commented Jan 25, 2024

I was told that functions like element-hq/element-x-android#2116 or element-hq/element-x-android#2268 or element-hq/element-x-android#1472 would require functionality in the Rust SDK.

I cannot confirm whether that information is correct, or whether this functionality can be implemented solely on the application side without touching the SDK. But I didn't find an issue about this, so I thought, I'll create one to see what the status (and responsibility) of this is.

@frebib for reference.

@cyrneko
Copy link

cyrneko commented Jan 25, 2024

I think "Creating a timeline from a specific point in the history" from #1103 is intended to track this

@jplatte
Copy link
Collaborator

jplatte commented Jan 25, 2024

I think "Creating a timeline from a specific point in the history" from #1103 is intended to track this

Yes, exactly! 👍

@claell
Copy link
Author

claell commented Jan 26, 2024

Thanks for the hint!

So it is correct, that this can't be done solely on Client side, but requires the Rust SDK to have it? Are jumps in Element Web with Rust SDK not available, then?

And, if this is needed, is there a rough ETA? To me, some of the linked Element X Android issues are rather important for regular adoption.

@manuroe
Copy link
Contributor

manuroe commented Jan 26, 2024

Permalink support work is going to start in EX and in the SDK but there are several dependencies we want to complete before. The permalink support itself should be available end of April.
I am closing this issue because it is a duplicate and "jump to message" is more an app feature than a SDK one.

@manuroe manuroe closed this as completed Jan 26, 2024
@jplatte jplatte closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2024
@bnjbvr
Copy link
Member

bnjbvr commented Jan 26, 2024

For what it's worth: with the assumption that the target message isn't too far in the past, it's possible to implement that functionality client-side by using backpagination in the (ui-crate) Timeline, or equivalently calling Room::messages() in a loop, until we find the message. Or using the Room::event_with_context which calls the /context endpoint, and may return a few messages before and after, if you don't mind the timeline not being continuous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants