Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timeline when members are synced #1406

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Update timeline when members are synced #1406

merged 5 commits into from
Feb 2, 2023

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Jan 25, 2023

… as it's not available when members for the room aren't synced.

Ready for testing.

@jplatte jplatte mentioned this pull request Jan 25, 2023
29 tasks
@jplatte jplatte changed the title refactor(sdk): Use TimelineDetails for sender profile Update timeline when members are synced Jan 26, 2023
@jplatte jplatte force-pushed the jplatte/profiles branch 2 times, most recently from e568da0 to ed73d1b Compare January 31, 2023 13:08
@jplatte jplatte marked this pull request as ready for review February 2, 2023 15:35
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be working beautifully ElX side, nicely done 👏

@jplatte
Copy link
Collaborator Author

jplatte commented Feb 2, 2023

sigh coverage not running again.

@jplatte jplatte closed this Feb 2, 2023
@jplatte jplatte reopened this Feb 2, 2023
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jplatte jplatte enabled auto-merge (rebase) February 2, 2023 16:31
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 73.11% // Head: 72.85% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (d8438a8) compared to base (d08606e).
Patch coverage: 38.82% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1406      +/-   ##
==========================================
- Coverage   73.11%   72.85%   -0.27%     
==========================================
  Files         121      121              
  Lines       13229    13282      +53     
==========================================
+ Hits         9673     9677       +4     
- Misses       3556     3605      +49     
Impacted Files Coverage Δ
crates/matrix-sdk/src/room/timeline/mod.rs 82.73% <0.00%> (-0.60%) ⬇️
crates/matrix-sdk/src/room/timeline/inner.rs 66.17% <7.31%> (-10.55%) ⬇️
crates/matrix-sdk/src/room/timeline/event_item.rs 50.47% <29.41%> (-2.08%) ⬇️
...ates/matrix-sdk/src/room/timeline/event_handler.rs 69.09% <96.00%> (+0.09%) ⬆️
crates/matrix-sdk/src/room/common.rs 84.61% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jplatte jplatte merged commit 47f8b6c into main Feb 2, 2023
@jplatte jplatte deleted the jplatte/profiles branch February 2, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants