Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose event sending errors through timeline item #1423

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Jan 30, 2023

… instead of through the return value of Timeline::send.

I think this should be easier to work with for users of the timeline API. cc @zecakeh

@jplatte jplatte requested a review from Hywan January 30, 2023 19:22
@jplatte jplatte mentioned this pull request Jan 30, 2023
29 tasks
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 72.93% // Head: 72.95% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (fcfa697) compared to base (e9cef35).
Patch coverage: 69.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1423      +/-   ##
==========================================
+ Coverage   72.93%   72.95%   +0.01%     
==========================================
  Files         120      120              
  Lines       13137    13139       +2     
==========================================
+ Hits         9581     9585       +4     
+ Misses       3556     3554       -2     
Impacted Files Coverage Δ
crates/matrix-sdk/src/room/timeline/event_item.rs 49.11% <60.00%> (+0.91%) ⬆️
crates/matrix-sdk/src/room/timeline/inner.rs 74.22% <70.00%> (+0.99%) ⬆️
crates/matrix-sdk/src/room/timeline/mod.rs 82.44% <80.00%> (-0.24%) ⬇️
...ates/matrix-sdk/src/room/timeline/event_handler.rs 68.63% <100.00%> (-0.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@zecakeh zecakeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@jplatte jplatte requested a review from poljar January 31, 2023 12:22
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving my PR :-).

@jplatte jplatte requested a review from Hywan February 1, 2023 10:51
@jplatte jplatte enabled auto-merge (rebase) February 2, 2023 08:59
@jplatte jplatte merged commit e068b49 into main Feb 2, 2023
@jplatte jplatte deleted the jplatte/timeline-refactor branch February 2, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants