-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose event sending errors through timeline item #1423
Conversation
Codecov ReportBase: 72.93% // Head: 72.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1423 +/- ##
==========================================
+ Coverage 72.93% 72.95% +0.01%
==========================================
Files 120 120
Lines 13137 13139 +2
==========================================
+ Hits 9581 9585 +4
+ Misses 3556 3554 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving my PR :-).
8650def
to
0fa7736
Compare
… instead of through the return value of Timeline::send.
f5bc70b
to
fcfa697
Compare
… instead of through the return value of Timeline::send.
I think this should be easier to work with for users of the timeline API. cc @zecakeh