-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffi: Expose filename and formatted body fields for media captions #3171
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3171 +/- ##
=======================================
Coverage 83.84% 83.84%
=======================================
Files 232 232
Lines 24005 24005
=======================================
+ Hits 20127 20128 +1
+ Misses 3878 3877 -1 ☔ View full report in Codecov by Sentry. |
Hi! Thanks for the PR, would you be willing to update Ruma as well? |
Maybe I'll have a try at the weekend (I'll probably have a look at updating this PR to prepare for ruma/ruma#1738 at some point either way), but if I remember correctly from last week, there were some compile issues with code I wasn't familiar with, so may be easier for someone else. Since I'm still somewhat of a Rust noob, I'm not planning to spend too much time on it, when it's likely that someone with better knowledge of the codebase will do that at some later point either way. |
In relevance to MSC2530
Looks like someone already updated ruma, so now the PR should already compile - just rebased it onto main to let the CI test. |
Thanks for the PR! I would prefer to wait on ruma/ruma#1738 to be merged before merging this one :-). |
The PR looks sensible though and should not be impacted by ruma/ruma#1738. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Enables clients to render media captions as per the recently merged MSC2530.
Related ruma PR: ruma/ruma#1732
Signed-off-by: Tobias Büttner [email protected]