crypto: Don't deep copy the OlmMachine when creating a notification client #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3992 +/- ##
==========================================
- Coverage 84.26% 84.25% -0.02%
==========================================
Files 266 266
Lines 28332 28336 +4
==========================================
- Hits 23875 23874 -1
- Misses 4457 4462 +5 ☔ View full report in Codecov by Sentry. |
poljar
force-pushed
the
poljar/notification-duplicate-olm-machine-fix
branch
from
2e96459
to
d4c51d6
Compare
bnjbvr
approved these changes
Sep 16, 2024
crates/matrix-sdk-ui/tests/integration/encryption_sync_service.rs
Outdated
Show resolved
Hide resolved
crates/matrix-sdk-ui/tests/integration/encryption_sync_service.rs
Outdated
Show resolved
Hide resolved
poljar
force-pushed
the
poljar/notification-duplicate-olm-machine-fix
branch
from
3635fe4
to
f32a795
Compare
poljar
force-pushed
the
poljar/notification-duplicate-olm-machine-fix
branch
from
f32a795
to
5db87b5
Compare
…nClient The NotificationClient, responsible for handling, fetching, and potentially decrypting events received via push notifications, creates a copy of the main Client object. During this process, the Client object is adjusted to use an in-memory state store to prevent concurrency issues from multiple sync loops attempting to write to the same database. This copying unintentionally recreated the OlmMachine with fresh data loaded from the database. If both Client instances were used for syncing without proper cross-process locking, forks of the vodozemac Account and Olm Sessions could be created and later persisted to the database. This behavior can lead to the duplication of one-time keys, cause sessions to lose their ability to decrypt messages, and result in the generation of undecryptable messages on the recipient’s side.
poljar
force-pushed
the
poljar/notification-duplicate-olm-machine-fix
branch
from
5db87b5
to
f590543
Compare
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft since I will want to make test for this. This closes: #1415.