feat(crypto-nodejs) Implement missing APIs #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
reviewed
May 31, 2022
Codecov Report
@@ Coverage Diff @@
## main #721 +/- ##
==========================================
- Coverage 71.61% 71.54% -0.07%
==========================================
Files 117 118 +1
Lines 16432 16487 +55
==========================================
+ Hits 11767 11796 +29
- Misses 4665 4691 +26
Continue to review full report at Codecov.
|
Hywan
force-pushed
the
feat-crypto-nodejs-next
branch
from
5447f96
to
af6e8a4
Compare
jplatte
reviewed
May 31, 2022
Hywan
force-pushed
the
feat-crypto-nodejs-next
branch
from
cd82085
to
dc7f038
Compare
Hywan
force-pushed
the
feat-crypto-nodejs-next
branch
from
cbd2e7c
to
7bb96e0
Compare
…iod_messages` are now `BigInt`.
Returning an `napi::Error` doesn't raise it. We must return a `Result<_, napi::Error>` to ensure `napi` will raise the error as expected.
…Requests` and `.markRequestAsSent`.
Hywan
force-pushed
the
feat-crypto-nodejs-next
branch
from
a37f400
to
12c53bb
Compare
jplatte
reviewed
Jun 7, 2022
Hywan
force-pushed
the
feat-crypto-nodejs-next
branch
from
125ce78
to
4dbddba
Compare
Hywan
force-pushed
the
feat-crypto-nodejs-next
branch
from
4c0361d
to
1b2c644
Compare
jplatte
reviewed
Jun 9, 2022
Hywan
force-pushed
the
feat-crypto-nodejs-next
branch
from
c9063d5
to
506f57a
Compare
jplatte
reviewed
Jun 9, 2022
Comment on lines
52
to
57
| let user_id = user_id.inner.clone(); | ||
| let device_id = device_id.inner.clone(); | ||
|
|
||
| OlmMachine { | ||
| inner: matrix_sdk_crypto::OlmMachine::new(user_id.as_ref(), device_id.as_ref()).await, | ||
| } |
There was a problem hiding this comment.
I think we should implement Deref<Target = ruma::UserId> for the nodejs UserId type, then this can be simplified to
Suggested change
| let user_id = user_id.inner.clone(); | |
| let device_id = device_id.inner.clone(); | |
| OlmMachine { | |
| inner: matrix_sdk_crypto::OlmMachine::new(user_id.as_ref(), device_id.as_ref()).await, | |
| } | |
| OlmMachine { | |
| inner: matrix_sdk_crypto::OlmMachine::new(user_id, device_id).await, | |
| } |
jplatte
approved these changes
Jun 9, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #699.
The work has started in #675. This PR is the sequel of it.
Progress
The methods that are needed for basic encryption/decryption are:
OlmMachine::new()->OlmMachine::initialize()(since JavaScript cannot have async constructor, we use the factory pattern)OlmMachine::receive_sync_changes()OlmMachine::outgoing_requests()OlmMachine::mark_request_as_sent()OlmMachine::decrypt_room_event()OlmMachine::update_tracked_users()OlmMachine::get_missing_sessions()OlmMachine::share_room_key()OlmMachine::encrypt_raw()Bonus:
OlmMachine::user_id()OlmMachine::device_id()OlmMachine::identity_keys()Note: This PR includes #723 temporarily.Other tasks than the binding itself:
README.mdis written (and helpful)