Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open API: getRoomKeys is missing required flag #3485

Closed
Dominaezzz opened this issue Nov 13, 2021 · 1 comment · Fixed by #3509
Closed

Open API: getRoomKeys is missing required flag #3485

Dominaezzz opened this issue Nov 13, 2021 · 1 comment · Fixed by #3509
Labels
aesthetic A suggestion or issue relating to the representation of the spec

Comments

@Dominaezzz
Copy link
Contributor

Link to problem area:

https://github.com/matrix-org/matrix-doc/blob/1ad5ff4179cfa2b62d6be47ad6ed8bde95ec2e41/data/api/client-server/key_backup.yaml#L852-L880

Issue

This field is missing required: true like is done here.
The description says that if no keys are found, then empty (but not omitted) rooms property will be returned.

This whole schema should probably just be de-duplicated into the definitions folder like so.
@Dominaezzz Dominaezzz added the aesthetic A suggestion or issue relating to the representation of the spec label Nov 13, 2021
@ankur12-1610
Copy link
Contributor

I'll work on this!

@ankur12-1610 ankur12-1610 mentioned this issue Nov 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aesthetic A suggestion or issue relating to the representation of the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OpenAPI: Add missing required flag in getRoomKeys
2 participants
@Dominaezzz @ankur12-1610