Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI: Add missing required flag in getRoomKeys #3509

Merged
merged 2 commits into from
Nov 22, 2021
Merged

OpenAPI: Add missing required flag in getRoomKeys #3509

merged 2 commits into from
Nov 22, 2021

Conversation

ankur12-1610
Copy link
Contributor

@ankur12-1610 ankur12-1610 commented Nov 19, 2021

Added missing required flag in getRoomKeys in matrix-doc/data/api/client-server/key_backup.yaml.

Fixes: #3485

Signed-off-by: ankur12-1610 [email protected]

Preview: https://pr3509--matrix-org-previews.netlify.app

@ankur12-1610
Copy link
Contributor Author

@Dominaezzz can you review the changes?

@Dominaezzz
Copy link
Contributor

https://pr3509--matrix-org-previews.netlify.app/client-server-api/#get_matrixclientv3room_keyskeys
Doesn't look like it's been reflected in the spec?

@richvdh richvdh changed the title Open API: Added missing required flag in getRoomKeys OpenAPI: Add missing required flag in getRoomKeys Nov 19, 2021
@ankur12-1610
Copy link
Contributor Author

https://pr3509--matrix-org-previews.netlify.app/client-server-api/#get_matrixclientv3room_keyskeys Doesn't look like it's been reflected in the spec?

I'll look into it 😅
Did I place it in wrong place? :')

@Dominaezzz
Copy link
Contributor

Was on my phone so I couldn't check easily.

It's almost in the right place, it's just indented too far. Removing 4 spaces should do the trick I think.

@ankur12-1610
Copy link
Contributor Author

Was on my phone so I couldn't check easily.

It's almost in the right place, it's just indented too far. Removing 4 spaces should do the trick I think.

@Dominaezzz, Done :)

Copy link
Contributor

@Dominaezzz Dominaezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it worked! 😄

Dominaezzz added a commit to Dominaezzz/matrix-kt that referenced this pull request Nov 21, 2021
@uhoreg uhoreg merged commit ac98c8c into matrix-org:main Nov 22, 2021
Dominaezzz added a commit to Dominaezzz/matrix-kt that referenced this pull request Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open API: getRoomKeys is missing required flag
3 participants