Several improvements to speculator to prepare it for actually being used by the masses, not just us devs #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commented on the commits themselves. LGTM other than comments/queries. /me slowly absorbs more Go syntax (in this case, named result parameters) |
Also, drop permissions from 0755 to 0700
|
Replied to everything, PTAL |
|
LGTM |
illicitonion
force-pushed
the
daniel/speculatorhardening
branch
from
e65b6fe
to
6a6cbd9
Compare
illicitonion
added a commit
that referenced
this pull request
Nov 23, 2015
Several improvements to speculator to prepare it for actually being used by the masses, not just us devs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit stands alone as a small improvement, but they are co-dependent enough not to send separately.
I would recommend reviewing commit-by-commit.