Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2774: Expose the widget ID to the widget #2774

Merged
merged 2 commits into from
Nov 11, 2020
Merged

MSC2774: Expose the widget ID to the widget #2774

merged 2 commits into from
Nov 11, 2020

Conversation

turt2live
Copy link
Member

@turt2live turt2live added kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal proposal-in-review labels Sep 11, 2020
@turt2live
Copy link
Member Author

Implementation: matrix-org/matrix-widget-api@3fdfe4f

@turt2live
Copy link
Member Author

This seems fairly straightforward and no one has really opposed it, so:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Oct 2, 2020 •
edited by dbkr
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Oct 2, 2020
richvdh
richvdh approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine as long as we're happy to stick with the current mechanism for URL templating.

I read https://15631-24998719-gh.circle-artifacts.com/0/scripts/gen/widgets/unstable.html#url-templating (from #2764) and wondered if it needed to be clearer about what escaping is expected: for example, does the client need to care if the param is in the query string or the fragment?

That's orthogonal here though.

dbkr
dbkr reviewed Oct 9, 2020
View reviewed changes
proposals/2774-widget-id.md Outdated Show resolved Hide resolved
proposals/2774-widget-id.md Show resolved Hide resolved
@turt2live @dbkr
spelling
411202f 
Co-authored-by: David Baker <[email protected]>
@mscbot
Copy link
Collaborator

mscbot commented Nov 6, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Nov 6, 2020
@mscbot
Copy link
Collaborator

mscbot commented Nov 11, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Nov 11, 2020
@turt2live turt2live merged commit 940bb49 into master Nov 11, 2020
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Nov 11, 2020
@turt2live turt2live self-assigned this Nov 11, 2020
turt2live added a commit that referenced this pull request Nov 23, 2020
@turt2live
Specify matrix_widget_id template variable per MSC2774
d5927ec 
#2774
@turt2live turt2live mentioned this pull request Nov 23, 2020
Draft
6 tasks
@turt2live turt2live removed the spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec label Nov 23, 2020
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review widgets anything to do with widgets labels Nov 23, 2020
@turt2live turt2live added the blocked Something needs to be done before action can be taken on this PR/issue. label Apr 6, 2021
@ShadowJonathan ShadowJonathan mentioned this pull request Feb 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr left review comments

@richvdh richvdh richvdh approved these changes

Assignees

@turt2live turt2live

Labels
blocked Something needs to be done before action can be taken on this PR/issue. kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal spec-pr-in-review A proposal which has been PR'd against the spec and is in review widgets anything to do with widgets
Projects
Spec Core Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turt2live @mscbot @dbkr @richvdh