Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to use
TimelineView
. We have to figure out our own layout but does get rid of some of theRoomView
boilerplate. TheTimelineView
still has outside boilerplate styles to work.There shouldn't be any visible change:
Why are we switching from
RoomView
toTimelineView
Also aligns with what Chatterbox has to do SDK wise. Our layout aligns more with Hydrogen which is why we originally used
RoomView
though.Also a soft pre-requisite for #114 so we can more easily pass options to
TimelineView
to change how the scroll works. Although we could work around and pass options throughRoomView
if necessary.Todo
Make sure the page loads with the timeline scrolled to the bottommain
and previous revisions.Timeline_scroller
,$0.scrollHeight - $0.scrollTop - $0.clientHeight
=56px
)