Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jump forward and backward seamlessly #121

Merged
merged 6 commits into from
Nov 3, 2022
Merged

Jump forward and backward seamlessly #121

merged 6 commits into from
Nov 3, 2022

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Nov 3, 2022 •
edited
Loading

Jump forward and backward seamlessly.

Fix #120
Follow-up to #114

  • Uses event permalinking (?at=$xxx) to continue the scroll where you should start reading again.
  • When we jump forwards, we make sure that we go a day back to ensure there isn't more than the page limit between where we jumped from and the day so we don't lose any messages in a gap.

Todo

  • Add message highlight where ?at=$abc is continuing from
  • Center highlighted message on page-load
  • Update with latest Hydrogen scratch changes

@MadLittleMods MadLittleMods added T-Defect Something isn't working. Bugs, crashes, or other reported issues. A-archive-room-view The view to look at a room day by day in the archive labels Nov 3, 2022
@MadLittleMods MadLittleMods changed the title Jump forward seamlessly Jump forward and backward seamlessly Nov 3, 2022
MadLittleMods added a commit that referenced this pull request Nov 3, 2022
@MadLittleMods
Refactor fetchEndpointAsText to return res alongside data
cbef407 
Split out of #121
where we use `res.url`.
@MadLittleMods MadLittleMods mentioned this pull request Nov 3, 2022
Merged
MadLittleMods added a commit that referenced this pull request Nov 3, 2022
@MadLittleMods
Refactor fetchEndpointAsText/fetchEndpointAsJson to return res …
2dff7ec 
…alongside `data` (#122)

Split out of #121
where we needed to use `res.url`.
@MadLittleMods
Merge branch 'main' into madlittlemods/120-seamless-jumps
956fded 
Conflicts:
	server/lib/fetch-endpoint.js
	test/e2e-tests.js
@MadLittleMods MadLittleMods mentioned this pull request Nov 3, 2022
Merged
1 task
MadLittleMods added a commit that referenced this pull request Nov 3, 2022
@MadLittleMods
Add permalink highlighting - ?at=$xxx (#123)
5bae040 
ex.
```
http://localhost:3050/r/test-room1:my.synapse.server/date/2022/07/28?at=$O9fDg42JoSh9VdcL820FDUS0Gi_CkPt_hrN1pK1fPEY
````

Fix #4

Split out from #121
@MadLittleMods MadLittleMods marked this pull request as ready for review November 3, 2022 10:06
@MadLittleMods MadLittleMods merged commit 026a08a into main Nov 3, 2022
@MadLittleMods MadLittleMods added the A-backend Related to the backend Node.js server pieces label Apr 11, 2023
@MadLittleMods MadLittleMods deleted the madlittlemods/120-seamless-jumps branch April 26, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-archive-room-view The view to look at a room day by day in the archive A-backend Related to the backend Node.js server pieces T-Defect Something isn't working. Bugs, crashes, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jumping forward and backward isn't stable and not completely seamless
1 participant
@MadLittleMods