Reduce logic further

matrix-org · Sep 20, 2024 · 0c75c17 · 0c75c17
1 parent a51cd63
commit 0c75c17
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/protections/MentionSpam.ts b/src/protections/MentionSpam.ts
@@ -40,10 +40,8 @@ export class MentionSpam extends Protection {
 
     public checkMentions(body: unknown|undefined, htmlBody: unknown|undefined, mentionArray: unknown|undefined): boolean {
         const max = this.settings.maxMentions.value;
-        if (Array.isArray(mentionArray)) {
-            if (mentionArray.length > this.settings.maxMentions.value) {
-                return true;
-            }
+        if (Array.isArray(mentionArray) && mentionArray.length > max) {
+            return true;
         }
         if (typeof body === "string" && body.split('@').length - 1 > max) {
             return true;