Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch up with bug-fix relevant PRs on node-irc #19

Closed
kegsay opened this issue Feb 1, 2017 · 6 comments
Closed

Catch up with bug-fix relevant PRs on node-irc #19

kegsay opened this issue Feb 1, 2017 · 6 comments

Comments

@kegsay
Copy link
Member

kegsay commented Feb 1, 2017

The following are relevant to us:
@kegsay
Copy link
Member Author

kegsay commented Mar 29, 2017

martynsmith#507 possibly.

@t3chguy t3chguy mentioned this issue Apr 13, 2017
Merged
@intelfx
Copy link

intelfx commented Jan 7, 2018

Should probably be closed as #22 is merged.

@kegsay kegsay closed this as completed Jan 8, 2018
@chrisdotcode
Copy link

@kegsay We haven't merged martynsmith#507 as of yet.

@intelfx
Copy link

intelfx commented Jan 9, 2018

@chrisdotcode Isn't it an issue (as opposed to a PR)?

@chrisdotcode
Copy link

Yeah, good point. It's at least worth keeping in maybe to implement soon.

@xzfc
Copy link

xzfc commented Aug 2, 2018

I've fixed it in #30, can someone review please?

Half-Shot pushed a commit that referenced this issue Feb 23, 2019
@Throne3d
Fix issue #19 by adding support for error 477
5e9df32 
Sadly, according to
http://defs.ircdocs.horse/defs/numerics.html#err-nochanmodes-477
it looks like error 477 has conflicting usage:

- ERR_NOCHANMODES (by RFC2812 spec)
- ERR_NEEDREGGEDNICK (with Bahamut, ircu, Unreal)

This commit allows codes to just specify a type, instead
of also a name, and adds a test to ensure this code is
parsed as expected.

It also fixes up the order of actual/expected in
test-parse-line.js's t.equal calls, and makes the messages
more grammatical in context (describe the test, not the
success).
Half-Shot pushed a commit that referenced this issue Feb 23, 2019
@Throne3d
Merge pull request #23 from Throne3d/fix/19-error477
2888078 
Fix issue #19 by adding support for error 477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@intelfx @chrisdotcode @xzfc @kegsay