Azren/split up main #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 22, 2021 09:51
Moved SQL outputting code into a seperate function Moved code that checks validity of compression to a seperate function
This means that the database changes will only be output if they are valid (otherwise may accidently carry out transactions!)
| fn main() { | ||
| #[allow(deprecated)] | ||
| let matches = App::new(crate_name!()) | ||
| struct Config { |
There was a problem hiding this comment.
I know that the code base doesn't really have them atm, but can you add doc comments to the new structs and functions to say what they do please?
There was a problem hiding this comment.
Ah sorry they're added in azren/documented_lib
erikjohnston
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved code from inside the main function into function calls