Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give clients avatar URLs for rooms #208

Merged
merged 13 commits into from
Jul 19, 2023
Merged

Give clients avatar URLs for rooms #208

merged 13 commits into from
Jul 19, 2023

Commits on Jul 18, 2023

  1. MatchRoomSubscription: include room ID in err msg

    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    790ae22 View commit details
    Browse the repository at this point in the history

  2. Improve MatchResponse errmsg formatting 

    - Print it out in red so you can spot it easily in a long test log
- Pretty print the response json, because life's too short to train your
  brain to be a JSON parser.
    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    4eb9bcc View commit details
    Browse the repository at this point in the history

  3. Add helper Matcher for logging the rooms section 

    Useful for debugging a test.
    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    64183a3 View commit details
    Browse the repository at this point in the history

  4. Define avatar field on sync3.Room

    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    59a6554 View commit details
    Browse the repository at this point in the history

  5. Test helper for setting an avatar 

    Expose this on CSAPI for tests to use too.

Also update SlidingSyncUntilMembership to check the membership only.
Otherwise it would try to match an avatar. In 99% of cases this would be
fine, but things like per-room avatars (or indeed per-room displaynames)
would screw this up.
    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    5ac3430 View commit details
    Browse the repository at this point in the history

  6. Don't create two Heroes slices to the same array 

    Otherwise you end up with two slices that share ownership of the same
data but don't coordinate between one another, see e.g.
https://go.dev/play/p/uk3o652Tvye
    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    3861bac View commit details
    Browse the repository at this point in the history

  7. Parse m.room.avatar

    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    5913fbb View commit details
    Browse the repository at this point in the history

  8. Track heroes' avatars

    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    7097c1d View commit details
    Browse the repository at this point in the history

  9. Track changes to avatars when computing deltas

    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    6b9a221 View commit details
    Browse the repository at this point in the history

  10. Fix comment typo

    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    065dcd4 View commit details
    Browse the repository at this point in the history

  11. Test cases

    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    a02a559 View commit details
    Browse the repository at this point in the history

  12. Fix an integration test failure

    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    b4ba770 View commit details
    Browse the repository at this point in the history

  13. Lookup correct m.room.avatar field for invites

    David Robertson committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    885b42d View commit details
    Browse the repository at this point in the history