Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to cleanup dead invites #351

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

DMRobertson
Copy link
Contributor

Fixes #350.

Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good when SELECTing on m.org - needs tests though.


// Alice and Bob have invites to rooms X and Y.
// Chris has an invite to room Z.
t.Log("Alice is joined to room X; Bob to room Y. Chris isn't joined to any rooms.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log line is confusing and wrong? Wrong position in the test and Bob is banned from room Y, not joined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks.

@DMRobertson DMRobertson merged commit dae2fa3 into main Oct 19, 2023
7 checks passed
@DMRobertson DMRobertson deleted the dmr/cleanup-dead-invites branch October 19, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invites are not always correctly handled over federation
2 participants