Cancel outstanding requests when destroying conns #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
commented
Oct 26, 2023
tests-e2e/handler_test.go
Outdated
Comment on lines
82
to
84
| if response.duration > cancelWithin { | ||
| t.Errorf("Waited for %s, but expected second sync to cancel after at most %s", response.duration, cancelWithin) | ||
| } |
There was a problem hiding this comment.
This was my attempt to detect if the request was cancelled early.
I did wonder about explicitly making a request with client-created context. But I wasn't sure if http.Client would mark the context as Done when the request ends.
There was a problem hiding this comment.
But I wasn't sure if http.Client would mark the context as Done when the request ends.
seemingly not. That makes the test much cleaner.
kegsay
approved these changes
Oct 27, 2023
sync3/handler/connstate.go
Outdated
| @@ -723,6 +724,8 @@ func (s *ConnState) trackProcessDuration(ctx context.Context, dur time.Duration, | |||
| // Called when the connection is torn down | |||
| func (s *ConnState) Destroy() { | |||
| s.userCache.Unsubscribe(s.userCacheID) | |||
| logger.Debug().Str("user_id", s.userID).Str("device_id", s.deviceID).Msg("cancelling any in-flight requests") | |||
| s.cancelLatestReq() | |||
Grr. Is there no tooling for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will help with #294.