Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle prometheus and sentry into the Docker image #519

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Bundle prometheus and sentry into the Docker image #519

merged 2 commits into from
Jun 29, 2022

Conversation

benbz
Copy link
Contributor

@benbz benbz commented Jun 29, 2022

Pull Request Checklist

  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fix a bug that prevented receiving messages from other servers." instead of "Move X method from EventStore to EventWorkerStore.".
    • Include 'Contributed by Your Name.' or 'Contributed by @your-github-username.' — unless you would prefer not to be credited in the changelog.
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off

Re-does #325 post-poetry.

As of poetry 1.2.0b2 / python-poetry/poetry#5452 this can be done with --all-extras instead

@benbz benbz requested a review from a team as a code owner June 29, 2022 09:28
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I must have missed this in the poetry work.

I sanity checked that the docker file builds and that it contains prometheus and sentry in the venv. LGTM!

@DMRobertson DMRobertson merged commit edd2306 into matrix-org:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants