Pin CI checks to Python 3.12 #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 20, 2023 18:29
Bump the version in pyproject.toml, then `poetry lock --no-update`. 3.7 was EOLed 27 Jun 2023
This didn't have a way to pin the Python version in use. We haven't found pulling this out to be useful, so instead let's just inline it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #581 by updating locked versions of deps with C extensions to include 3.12 wheels. To do so, drop Python 3.7 support. This has EOLed, and without it Poetry refuses to update cffi (whose most recent release requirses Python >= 3.8).
Also pin the python version used in CI. To do so, inline the config that we pulled in from https://github.com/matrix-org/backend-meta/blob/release/v2/.github/workflows/python-poetry-ci.yml. (That doesn't expose an option to pin the Python version, and we haven't used that workflow anywhere else, really.)
Commitwise reviewable.