Quieten tests. (#149)

matrix-org · Aug 19, 2020 · 1a6ead7 · 1a6ead7
1 parent 77338ee
commit 1a6ead7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/149.misc b/changelog.d/149.misc
@@ -0,0 +1 @@
+Remove a source of nuisance, noisy (but otherwise harmless) exceptions in tests.
diff --git a/tests/test_apns.py b/tests/test_apns.py
@@ -68,7 +68,7 @@ def test_payload_truncation(self):
         """
         # Arrange
         method = self.apns_pushkin_snotif
-        method.return_value = testutils.make_async_magic_mock(
+        method.side_effect = testutils.make_async_magic_mock(
             NotificationResult("notID", "200")
         )
         self.sygnal.pushkins[PUSHKIN_ID].MAX_JSON_BODY_SIZE = 240
@@ -91,7 +91,7 @@ def test_payload_truncation_test_validity(self):
         """
         # Arrange
         method = self.apns_pushkin_snotif
-        method.return_value = testutils.make_async_magic_mock(
+        method.side_effect = testutils.make_async_magic_mock(
             NotificationResult("notID", "200")
         )
         self.sygnal.pushkins[PUSHKIN_ID].MAX_JSON_BODY_SIZE = 4096