Reuse Configurations With Asterisk App IDs and Token Based APNS Auth #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ismailgulek <[email protected]>
Signed-off-by: ismailgulek <[email protected]>
ismailgulek
changed the title
Signed-off-by: ismailgulek <[email protected]>
Signed-off-by: ismailgulek <[email protected]>
babolivier
suggested changes
Apr 24, 2020
Update doc Co-Authored-By: Brendan Abolivier <[email protected]>
Update doc Co-Authored-By: Brendan Abolivier <[email protected]>
+1. please don't just send in PRs without any description whatsoever about what they are supposed to do and why. |
Signed-off-by: ismailgulek <[email protected]>
Signed-off-by: ismailgulek <[email protected]>
babolivier
approved these changes
Apr 24, 2020
Update doc Co-Authored-By: Brendan Abolivier <[email protected]>
|
ahhhh, "asterisk" as in wildcard, as opposed to "Asterisk" as in the popular telephony software... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to enable having appId's like im.vector.* in sygnal.yaml file, which will enable using the same authentication to APNS against multiple appId's.
It also aims to enable token-based authentication for APNS, which is the only way to reuse authentication when notifying multiple apps.