set time-to-live for webpush messages #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callahad
reviewed
Mar 26, 2021
sygnal/webpushpushkin.py
Outdated
Comment on lines
123
to
128
| self.ttl = self.get_config("ttl") | ||
| if self.ttl: | ||
| if not isinstance(self.ttl, int): | ||
| raise PushkinSetupException("'ttl' must be an int if set") | ||
| else: | ||
| self.ttl = DEFAULT_TTL |
There was a problem hiding this comment.
Would it be cleaner to do this?
self.ttl = self.get_config("ttl", DEFAULT_TTL)
if not isinstance(self.ttl, int):
raise PushkinSetupException("'ttl' must be an int if set")
|
Do we need to document the Does |
|
Thanks for the review @callahad, ready for another look. |
|
r+ once CI passes and if you promise that you've tested this locally and it at least appears to work. |
callahad
approved these changes
Mar 29, 2021
|
@callahad Have tested again, all seems to work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurable with a default of 15 minutes.