Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings about finish() after disconnect #84

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Fix warnings about finish() after disconnect #84

merged 2 commits into from
Mar 24, 2020

Commits on Mar 23, 2020

  1. Change how we stub out HTTP requests in the tests 

    By having a FakeChannel instead of a DummyRequest, we can make sure that
functionality which relies on our own Request impl works correctly.
    @richvdh
    richvdh committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    b09dc68 View commit details
    Browse the repository at this point in the history

  2. Fix warnings about finish() after disconnect

    @richvdh
    richvdh committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    6f36624 View commit details
    Browse the repository at this point in the history