don't filter membership events based on history visibility (#3874)

don't filter membership events based on history visibility as we will already have filtered the messages in the timeline, and state events are always visible. and because @erikjohnston said so.
matrix-org · Sep 14, 2018 · 024be6c · 024be6c
1 parent 3e6e94f
commit 024be6c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/changelog.d/3874.bugfix b/changelog.d/3874.bugfix
diff --git a/synapse/handlers/pagination.py b/synapse/handlers/pagination.py
@@ -269,14 +269,7 @@ def get_messages(self, requester, room_id=None, pagin_config=None,
 
             if state_ids:
                 state = yield self.store.get_events(list(state_ids.values()))
-
-            if state:
-                state = yield filter_events_for_client(
-                    self.store,
-                    user_id,
-                    state.values(),
-                    is_peeking=(member_event_id is None),
-                )
+                state = state.values()
 
         time_now = self.clock.time_msec()