Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Docker: only copy what we need to the build image (#4562)
Browse files Browse the repository at this point in the history
There are two reasons this is a good thing:

 * first, it means that you don't end up with stuff kicking around your working
   copy ending up in the build image by mistake (which can upset the pip
   install process)

 * second: it means that the docker image cache is more effective, and we can
   reuse docker images when iterating on the docker stuff.
  • Loading branch information
richvdh authored Feb 5, 2019
1 parent bf1e4d9 commit 3ef71a6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.d/4562.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Docker: only copy what we need to the build image
5 changes: 4 additions & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ RUN pip install --prefix="/install" --no-warn-script-location \

# now install synapse and all of the python deps to /install.

COPY . /synapse
COPY synapse /synapse/synapse/
COPY scripts /synapse/scripts/
COPY MANIFEST.in README.rst setup.py synctl /synapse/

RUN pip install --prefix="/install" --no-warn-script-location \
/synapse[all]

Expand Down

0 comments on commit 3ef71a6

Please sign in to comment.