Hopefully, fix LaterGuage error handling

matrix-org · Jun 4, 2018 · 694968f · 694968f
1 parent 5dbf305
commit 694968f
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/synapse/metrics/__init__.py b/synapse/metrics/__init__.py
@@ -60,10 +60,13 @@ def collect(self):
 
         try:
             calls = self.caller()
-        except Exception as e:
-            print(e)
-            logger.err()
+        except Exception:
+            logger.exception(
+                "Exception running callback for LaterGuage(%s)",
+                self.name,
+            )
             yield g
+            return
 
         if isinstance(calls, dict):
             for k, v in calls.items():