Return a BAD_ALIAS error code if the alias does not point to the room.

matrix-org · Mar 2, 2020 · d183d8a · d183d8a
1 parent c262f2f
commit d183d8a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/synapse/api/errors.py b/synapse/api/errors.py
@@ -66,6 +66,7 @@ class Codes(object):
     EXPIRED_ACCOUNT = "ORG_MATRIX_EXPIRED_ACCOUNT"
     INVALID_SIGNATURE = "M_INVALID_SIGNATURE"
     USER_DEACTIVATED = "M_USER_DEACTIVATED"
+    BAD_ALIAS = "M_BAD_ALIAS"
 
 
 class CodeMessageException(RuntimeError):

diff --git a/synapse/handlers/message.py b/synapse/handlers/message.py
@@ -912,7 +912,7 @@ def persist_and_notify_client_event(
                     raise SynapseError(
                         400,
                         "Room alias %s does not point to the room" % (room_alias_str,),
-                        Codes.NOT_FOUND,
+                        Codes.BAD_ALIAS,
                     )
 
             # Check that alt_aliases is the proper form.
@@ -939,7 +939,7 @@ def persist_and_notify_client_event(
                             400,
                             "Room alias %s does not point to the room"
                             % (room_alias_str,),
-                            Codes.NOT_FOUND,
+                            Codes.BAD_ALIAS,
                         )
 
         federation_handler = self.hs.get_handlers().federation_handler