Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Room types other than spaces don't carry over room upgrade #11896

Closed
Mikaela opened this issue Feb 2, 2022 · 2 comments · Fixed by #12786
Closed

Room types other than spaces don't carry over room upgrade #11896

Mikaela opened this issue Feb 2, 2022 · 2 comments · Fixed by #12786
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@Mikaela
Copy link
Contributor

Mikaela commented Feb 2, 2022

Description

I cannot upgrade a story room (matrix-org/matrix-spec-proposals#3588), because Synapse only carries over room type for spaces (#10774 via https://github.com/matrix-org/matrix-doc/issues/3451#issuecomment-1018481016). At https://github.com/matrix-org/matrix-doc/issues/3451#issuecomment-1028237354 and matrix-spec room Travis says that this is an implementation issue. (I don't know how does matrix-org/matrix-spec-proposals#3385 tie in with this).

Steps to reproduce

  1. Create a story room in FluffyChat
  2. /upgraderoom the Story room in Element Web
  3. The story room loses the room type and now it's a normal room

I expected the story room to stay a story room keeping the room type.

Version information

  • Homeserver: matrix.org

  • Version: I don't know

  • Install method: I don't know

  • Platform: I don't know

@Mikaela
Copy link
Contributor Author

Mikaela commented Feb 21, 2022

More reason why I would like to upgrade to room version 9 is that the MAC to make it default was merged matrix-org/matrix-spec-proposals#3589.

I am also looking forwards to matrix-org/matrix-spec-proposals#3613 which I hope will be a part of matrix-org/matrix-spec-proposals#3604.

@erikjohnston erikjohnston added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Feb 23, 2022
@Mikaela
Copy link
Contributor Author

Mikaela commented May 18, 2022

There is an MSC at matrix-org/matrix-spec-proposals#3818

Mikaela added a commit to Mikaela/synapse that referenced this issue May 18, 2022
Resolves: matrix-org#11896

Signed-off-by: Aminda Suomalainen <[email protected]>
Mikaela added a commit to Mikaela/synapse that referenced this issue May 18, 2022
Resolves: matrix-org#11896

Signed-off-by: Aminda Suomalainen <[email protected]>
Mikaela added a commit to Mikaela/synapse that referenced this issue May 18, 2022
Resolves: matrix-org#11896

Signed-off-by: Aminda Suomalainen <[email protected]>
Mikaela added a commit to Mikaela/synapse that referenced this issue May 18, 2022
Resolves: matrix-org#11896

Signed-off-by: Aminda Suomalainen <[email protected]>
squahtx pushed a commit that referenced this issue May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants