Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Trace details of the concurrent calls within _check_sigs_and_hash_and_fetch #13587

Closed
MadLittleMods opened this issue Aug 22, 2022 · 0 comments · Fixed by #13588
Closed

Trace details of the concurrent calls within _check_sigs_and_hash_and_fetch #13587

MadLittleMods opened this issue Aug 22, 2022 · 0 comments · Fixed by #13588
Assignees
@MadLittleMods
Labels
A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Aug 22, 2022 •
edited
Loading

Trace details of the concurrent calls within _check_sigs_and_hash_and_fetch.

You can see that we're missing where all of the time went in this /messages trace while backfilling (_check_sigs_and_hash_and_fetch took 10.41s, only processing 100 events):

Breakdown of child spans in _check_sigs_and_hash_and_fetch in a Jaeger trace

More of the trace for context:

_check_sigs_and_hash_and_fetch taking 10s in a Jaeger trace
@MadLittleMods MadLittleMods added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) labels Aug 22, 2022
@MadLittleMods MadLittleMods self-assigned this Aug 22, 2022
MadLittleMods added a commit that referenced this issue Aug 22, 2022
@MadLittleMods
Trace time in _check_sigs_and_hash_and_fetch
28fb5d0 
Fix #13587
@MadLittleMods MadLittleMods mentioned this issue Aug 22, 2022
Merged
4 tasks
MadLittleMods added a commit that referenced this issue Aug 24, 2022
@MadLittleMods
Instrument _check_sigs_and_hash_and_fetch to trace time spent in ch…
7af07f9 
…ild concurrent calls (#13588)

Instrument `_check_sigs_and_hash_and_fetch` to trace time spent in child concurrent calls because I've see `_check_sigs_and_hash_and_fetch` take [10.41s to process 100 events](#13587)

Fix #13587

Part of #13356
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MadLittleMods MadLittleMods

Labels
A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
1 participant
@MadLittleMods