This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Implement trial users #3749
Merged
Implement trial users #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ara4n
approved these changes
Aug 23, 2018
| ) | ||
|
|
||
|
|
||
| class TestMauLimit(unittest.TestCase): |
There was a problem hiding this comment.
given we already have test_monthly_active_users perhaps this should go there? or be renamed test_trial_mau?
There was a problem hiding this comment.
I kept them separate because this is doing a full integration type test, while the other ones do more unit test style stuff with mocking
|
Build error looks like flakey test: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at #3744, copies a bunch from there