-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
Lets users have N days before they get counted as an MAU
Won't this mean that if 1000 user sign up on the first day, with an MAU limit of 100, that those 1000 users will still be able to use the service after the 2 days are up? |
...and only promote them to non-trial if we have MAU headroom
oops, totally missed that. have changed it so that we explicitly track whether MAUs are trial or not, and if they're trial, we only let them be promoted to non-trial users if there's enough MAU headroom. |
right, this looks like it should work (although I haven't extended the tests to cover the concept of trial users yet, but at least if you don't specify a trial duration it works as well as it did before)... The changes boil down to:
I think this gives us what is needed? @erikjohnston PTAL. @rxl881, @AmandineLP cc'ing fyi. |
@neilisfragile suggests an easier way of doing this would be to just only insert users into the MAU table if they've been around for more than N trial days. This seems a lot simpler, and we could measure 'been around' based on looking at when the account was registered. I'm not seeing an obvious flaw, but before i charge off and implement that one, can someone sanity check it? |
only consider users MAU after they've been around N days. This is an alternative implementation to #3739 as suggested by @neilisfragile, which is much simpler as you just hold off adding users to the MAU table until they've been active for more than N days.
I went and implemented @neilisfragile's suggestion over at #3744 anyway; I can't seen an obvious problem with it. @erikjohnston you get to discard one (or more) of these, i think ;P |
obsoleted by #3749 - thanks @erikjohnston for picking it up. |
Lets users have N days before they get counted as an MAU