This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Docker: only copy what we need to the build image #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two reasons this is a good thing: * first, it means that you don't end up with stuff kicking around your working copy ending up in the build image by mistake (which can upset the pip install process) * second: it means that the docker image cache is more effective, and we can reuse docker images when iterating on the docker stuff.
hawkowl
approved these changes
Feb 5, 2019
Codecov Report
@@ Coverage Diff @@
## release-v0.99.0 #4562 +/- ##
===================================================
- Coverage 74.91% 74.47% -0.44%
===================================================
Files 338 338
Lines 34495 35093 +598
Branches 5619 5789 +170
===================================================
+ Hits 25841 26137 +296
- Misses 7071 7343 +272
- Partials 1583 1613 +30 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two reasons this is a good thing:
first, it means that you don't end up with stuff kicking around your working
copy ending up in the build image by mistake (which can upset the pip
install process)
second: it means that the docker image cache is more effective, and we can
reuse docker images when iterating on the docker stuff.