Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Regression in log context tracking #9048

Closed
erikjohnston opened this issue Jan 7, 2021 · 7 comments · Fixed by #9053
Closed

Regression in log context tracking #9048

erikjohnston opened this issue Jan 7, 2021 · 7 comments · Fixed by #9053
Labels
z-bug (Deprecated Label) z-p2 (Deprecated Label)

Comments

@erikjohnston
Copy link
Member

On both matrix.org and jki.re I'm seeing (on latest develop) a lot of:

2021-01-07 18:39:07,534 - synapse.util.metrics - 113 - WARNING - None - Starting metrics collection from sentinel context: metrics will be lost

which may mean a bunch of our metrics are inaccurate
@erikjohnston erikjohnston added z-bug (Deprecated Label) z-p2 (Deprecated Label) labels Jan 7, 2021
@richvdh
Copy link
Member

richvdh commented Jan 7, 2021

which may mean a bunch of our metrics are inaccurate

I think the problem has existed for a while: we're just reporting it now.

It will have been introduced by #8935, and I feel like the increased log spam makes this a release-blocker for 1.25.

@richvdh
Copy link
Member

richvdh commented Jan 7, 2021

scratch that, it will be #8939, which didn't make the release.

@erikjohnston
Copy link
Member Author

Agreed. I think the first step is to get it to log what block is being ignored, since we have the name there that should be easy.

@richvdh
Copy link
Member

richvdh commented Jan 7, 2021

(it's still a release-blocker, but for 1.26...)

@erikjohnston
Copy link
Member Author

Clearly we need a next-release blocker label...

erikjohnston added a commit that referenced this issue Jan 8, 2021
@erikjohnston
Fix "Starting metrics collection from sentinel context" errors
7dadae4 
Fixes #9048
@erikjohnston
Copy link
Member Author

Looks like it is in v1.25.0rc1

@erikjohnston
Copy link
Member Author

Oh, ignore me somehow I opened the wrong PR....

@erikjohnston erikjohnston mentioned this issue Jan 8, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
z-bug (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "Starting metrics collection from sentinel context" errors matrix-org/synapse
2 participants
@richvdh @erikjohnston