This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Move the docker image build to Github Actions #10416
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
39f080b
Move docker image build to GHA
richvdh 57b4ed2
Rename 10425.misc to 10416.misc
richvdh 378adc2
don't run on PRs.
richvdh 0634844
use `docker buildx inspect`
richvdh 8d28893
Merge remote-tracking branch 'origin/develop' into rav/docker_build
richvdh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
# GitHub actions workflow which builds and publishes the docker images. | ||
|
||
name: Build docker images | ||
|
||
on: | ||
push: | ||
tags: ["v*"] | ||
branches: [ master, main ] | ||
workflow_dispatch: | ||
|
||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Set up QEMU | ||
id: qemu | ||
uses: docker/setup-qemu-action@v1 | ||
with: | ||
platforms: arm64 | ||
|
||
- name: Set up Docker Buildx | ||
id: buildx | ||
uses: docker/setup-buildx-action@v1 | ||
|
||
- name: Inspect builder | ||
run: docker buildx inspect | ||
|
||
- name: Log in to DockerHub | ||
uses: docker/login-action@v1 | ||
with: | ||
username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
password: ${{ secrets.DOCKERHUB_TOKEN }} | ||
|
||
- name: Calculate docker image tag | ||
id: set-tag | ||
run: | | ||
case "${GITHUB_REF}" in | ||
refs/heads/master|refs/heads/main) | ||
tag=latest | ||
;; | ||
refs/tags/*) | ||
tag=${GITHUB_REF#refs/tags/} | ||
;; | ||
*) | ||
tag=${GITHUB_SHA} | ||
;; | ||
esac | ||
echo "::set-output name=tag::$tag" | ||
|
||
# for release builds, we want to get the amd64 image out asap, so first | ||
# we do an amd64-only build, before following up with a multiarch build. | ||
- name: Build and push amd64 | ||
uses: docker/build-push-action@v2 | ||
if: "${{ startsWith(github.ref, 'refs/tags/v' }}" | ||
with: | ||
push: true | ||
labels: "gitsha1=${{ github.sha }}" | ||
tags: "matrixdotorg/synapse:${{ steps.set-tag.outputs.tag }}" | ||
file: "docker/Dockerfile" | ||
platforms: linux/amd64 | ||
|
||
- name: Build and push all platforms | ||
uses: docker/build-push-action@v2 | ||
with: | ||
push: true | ||
labels: "gitsha1=${{ github.sha }}" | ||
tags: "matrixdotorg/synapse:${{ steps.set-tag.outputs.tag }}" | ||
file: "docker/Dockerfile" | ||
platforms: linux/amd64,linux/arm64 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Move docker image build to Github Actions. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we do both in parallel (which CircleCI was doing)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no it wasn't. It was building an amd64-only build first, before kicking off a parallel build of amd64+arm64.