Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Clean up federation event auth code #10539

Merged

Commits on Aug 4, 2021

  1. drop old-room hack

    pretty sure we don't need this any more.
    richvdh committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    b17a9b1 View commit details
    Browse the repository at this point in the history
  2. Remove incorrect comment about modifying context

    It doesn't look like the supplied context is ever modified.
    richvdh committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    c12940c View commit details
    Browse the repository at this point in the history
  3. Stop _auth_and_persist_event modifying its parameters

    This is only called in three places. Two of them don't pass `auth_events`, and
    the third doesn't use the dict after passing it in, so this should be non-functional.
    richvdh committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    da5976e View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. Stop _check_event_auth modifying its parameters

    `_check_event_auth` is only called in three places. `on_send_membership_event`
    doesn't pass an `auth_events`, and `prep` and `_auth_and_persist_event` do not
    use the map after passing it in.
    richvdh committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    9f3ff33 View commit details
    Browse the repository at this point in the history
  2. Stop _update_auth_events_and_context_for_auth modifying its parameters

    Return the updated auth event dict, rather than modifying the parameter.
    
    This is only called from `_check_event_auth`.
    richvdh committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    9c01fe1 View commit details
    Browse the repository at this point in the history
  3. Improve documentation on _auth_and_persist_event

    Rename `auth_events` parameter to better reflect what it contains.
    richvdh committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    eddd41b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    09173aa View commit details
    Browse the repository at this point in the history
  5. Improve documentation on _check_event_auth

    rename `auth_events` parameter to better describe what it contains
    richvdh committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    7c2488d View commit details
    Browse the repository at this point in the history
  6. changelog

    richvdh committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    b45fcfc View commit details
    Browse the repository at this point in the history