This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Clean up federation event auth code #10539
Merged
richvdh
merged 9 commits into
develop
from
rav/unpick_update_auth_events_and_context_for_auth/1
Aug 6, 2021
Merged
Clean up federation event auth code #10539
richvdh
merged 9 commits into
develop
from
rav/unpick_update_auth_events_and_context_for_auth/1
Aug 6, 2021
Commits on Aug 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b17a9b1 - Browse repository at this point
Copy the full SHA b17a9b1View commit details -
Remove incorrect comment about modifying
context
It doesn't look like the supplied context is ever modified.
Configuration menu - View commit details
-
Copy full SHA for c12940c - Browse repository at this point
Copy the full SHA c12940cView commit details -
Stop
_auth_and_persist_event
modifying its parametersThis is only called in three places. Two of them don't pass `auth_events`, and the third doesn't use the dict after passing it in, so this should be non-functional.
Configuration menu - View commit details
-
Copy full SHA for da5976e - Browse repository at this point
Copy the full SHA da5976eView commit details
Commits on Aug 5, 2021
-
Stop
_check_event_auth
modifying its parameters`_check_event_auth` is only called in three places. `on_send_membership_event` doesn't pass an `auth_events`, and `prep` and `_auth_and_persist_event` do not use the map after passing it in.
Configuration menu - View commit details
-
Copy full SHA for 9f3ff33 - Browse repository at this point
Copy the full SHA 9f3ff33View commit details -
Stop
_update_auth_events_and_context_for_auth
modifying its parametersReturn the updated auth event dict, rather than modifying the parameter. This is only called from `_check_event_auth`.
Configuration menu - View commit details
-
Copy full SHA for 9c01fe1 - Browse repository at this point
Copy the full SHA 9c01fe1View commit details -
Improve documentation on
_auth_and_persist_event
Rename `auth_events` parameter to better reflect what it contains.
Configuration menu - View commit details
-
Copy full SHA for eddd41b - Browse repository at this point
Copy the full SHA eddd41bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09173aa - Browse repository at this point
Copy the full SHA 09173aaView commit details -
Improve documentation on
_check_event_auth
rename `auth_events` parameter to better describe what it contains
Configuration menu - View commit details
-
Copy full SHA for 7c2488d - Browse repository at this point
Copy the full SHA 7c2488dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b45fcfc - Browse repository at this point
Copy the full SHA b45fcfcView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.