Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove unused tables room_stats_historical and user_stats_historical #11280

Merged
merged 5 commits into from
Nov 13, 2021
Merged

Remove unused tables room_stats_historical and user_stats_historical #11280

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22e7829
remove unused tables room_stats_historical and user_stats_historical
H-Shay Nov 9, 2021
33caefe
update changelog number
H-Shay Nov 9, 2021
14dd5fc
Bump schema compat version comment
H-Shay Nov 10, 2021
e456a69
make linter happy
H-Shay Nov 10, 2021
d035de3
Update comment to give more info
H-Shay Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/11280.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Drop unused db tables `room_stats_historical` and `user_stats_historical`.
3 changes: 2 additions & 1 deletion synapse/storage/schema/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,11 @@
Changes in SCHEMA_VERSION = 65:
- MSC2716: Remove unique event_id constraint from insertion_event_edges
because an insertion event can have multiple edges.
- Remove unused tables `user_stats_historical` and `room_stats_historical`.
"""


SCHEMA_COMPAT_VERSION = 60 # 60: "outlier" not in internal_metadata.
SCHEMA_COMPAT_VERSION = 61 # 60: "outlier" not in internal_metadata.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the comment need updating?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of wish we would do the same as above, where we kept historical descriptions and had a little more room to write something. Though maybe I'm missing the point of this comment.

I assume it's to describe why the value was last bumped.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I bump the comment to something like # 61: Remove unused tables user_stats_historical and room_stats_historical ? I didn't want to bump or delete it because I wasn't entirely sure why it was there ;) but it seem that the consensus is that it can go...

Copy link
Contributor

@reivilibre reivilibre Nov 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about not keeping historical descriptions before, but only a summary of the latest bump. See #10903 (comment) :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing to add to the review, other than to say 🎉 finally we get to use the SCHEMA_COMPAT_VERSION for its intended purpose!

"""Limit on how far the synapse codebase can be rolled back without breaking db compat

This value is stored in the database, and checked on startup. If the value in the
Expand Down
18 changes: 18 additions & 0 deletions ...torage/schema/main/delta/65/05_remove_room_stats_historical_and_user_stats_historical.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/* Copyright 2021 The Matrix.org Foundation C.I.C
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

--remove unused tables room_stats_historical and user_stats_historical--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL comments only need to start with -- to be counted as comments.

But if that's your preferred style, feel free to leave it!

DROP TABLE IF EXISTS room_stats_historical;
DROP TABLE IF EXISTS user_stats_historical;