This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Derive users to notify application services of edus from user streams in on_new_event
#11903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we were completely ignoring all users discovered from rooms being passed to this function.
I broke off this refactoring at _get_to_device_messages, as this PR would start to become much bigger otherwise.
anoadragon453
force-pushed
the
anoa/pass_all_users_to_as_edu
branch
from
be3f21c
to
d33ab60
Compare
anoadragon453
force-pushed
the
anoa/pass_all_users_to_as_edu
branch
from
8e76bdc
to
29f2b64
Compare
|
It turns out user and room streams are only created on calls to So using the streams here is not a good solution for this use-case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we were completely ignoring all users discovered from rooms being passed to
on_new_event, here:https://github.com/matrix-org/synapse/blob/c15d37575882b976a99e5e616d738d904ba3e754/synapse/notifier.py#L437-L438
Luckily, the only EDU-handling caller that sets the
roomsargument ofon_new_eventis the handler of device list updates, which haven't yet been sent to application services before. So this didn't cause any EDUs to get dropped on the floor. But it's something that we'll need to fix for implementing #11881.Note that this is separate from, and does not fix #11152.
Best reviewed commit-by-commit.