Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add MSC2716 to room capabilities #12516

Closed

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Apr 21, 2022

Add MSC2716 to room capabilities

Spawned from matrix-org/matrix-js-sdk#2299 (comment)

GET http://localhost:8008/_matrix/client/v3/capabilities

{
    "capabilities": {
        "m.room_versions": {
            "default": "9",
            "available": {
                "1": "stable",
                "2": "stable",
                "3": "stable",
                "4": "stable",
                "5": "stable",
                "6": "stable",
                "7": "stable",
                "8": "stable",
                "9": "stable",
                "org.matrix.msc2176": "unstable",
                "org.matrix.msc2716v3": "unstable"
            },
            "org.matrix.msc3244.room_capabilities": {
                "knock": {
                    "preferred": "7",
                    "support": [
                        "7",
                        "8",
                        "9",
                        "org.matrix.msc2716v3"
                    ]
                },
                "restricted": {
                    "preferred": "9",
                    "support": [
                        "8",
                        "9"
                    ]
                },
                "org.matrix.msc2716.historical": {
                    "preferred": "org.matrix.msc2716v3",
                    "support": [
                        "org.matrix.msc2716v3"
                    ]
                }
            }
        },
        "m.change_password": {
            "enabled": true
        },
        "m.set_displayname": {
            "enabled": true
        },
        "m.set_avatar_url": {
            "enabled": true
        },
        "m.3pid_changes": {
            "enabled": true
        }
    }
}

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@MadLittleMods MadLittleMods added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Apr 21, 2022
@MadLittleMods MadLittleMods marked this pull request as ready for review April 21, 2022 00:44
@MadLittleMods MadLittleMods requested a review from a team as a code owner April 21, 2022 00:44
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from my concerns about stacking on top of MSC3244 like this, I'd like to see MSC2716 updated to document this new behaviour.

synapse/api/room_versions.py Outdated Show resolved Hide resolved
synapse/rest/client/capabilities.py Outdated Show resolved Hide resolved
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid the blocker here is about landing MSC3244 and adding the new capabilities to MSC2716, rather than the details of the code.

@MadLittleMods
Copy link
Contributor Author

I'm afraid the blocker here is about landing MSC3244 and adding the new capabilities to MSC2716, rather than the details of the code.

Makes sense. We don't want MSC3244 to get scrapped and then have people relying on the behavior for MSC2716 to work 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants