This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Optimise backfill calculation #12522
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
cd4d26f
skip a dict construction
richvdh 9a68a56
Move some filtering and sorting logic earlier
richvdh 8843069
update some comments and logs
richvdh 8feaece
Use lists of tuples instead of Dicts
richvdh b945de6
Use an `attrs` to track backfill points
richvdh a1bd48f
Bail out when we find a visible extremity
richvdh cb88081
Use `get_events_as_list`
richvdh 1f0a63e
Include insertion events in the `filtered_extremities` checks
richvdh d285af2
Only request extremities which we think will be visible
richvdh 4ac692f
add a TODO comment
richvdh bdfa5a7
Make `get_successor_events` take a single event
richvdh a23e5a1
changelog
richvdh 881d794
Update synapse/handlers/federation.py
richvdh 8487963
More comment updates, per review
richvdh b75b3f5
Use a list rather than a set
richvdh 1dfe084
Update and rename 12522.misc to 12522.bugfix
richvdh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix a bug introduced in Synapse 0.99.3 which could cause Synapse to consume large amounts of RAM when back-paginating in a large room. | ||
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suppose we're in the worst case, where we have many backfill points to consider and none of them/their successor events are visible to us. Wouldn't we end up doing the same amount of work as before this change? (I.e. isn't this a bugfix for the best/average case rather than the worst?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we won't try to load all state maps into memory at the same time (which we used to do in the depths of
filter_events_for_server, in_event_to_memberships). So yeah, we might end up churning a bunch of CPU which we didn't before, but at least we won't OOM.