Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Upgrade to python 3.10 by default (#13234) #13237

Closed
wants to merge 1 commit into from

Conversation

melroy89
Copy link

@melroy89 melroy89 commented Jul 9, 2022

See title.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

Signed-off-by: Melroy van den Berg

Regards,
Melroy van den Berg

@melroy89 melroy89 requested a review from a team as a code owner July 9, 2022 16:53
@DMRobertson DMRobertson added this to the Revisit: Next Quarter milestone Jul 11, 2022
@DMRobertson DMRobertson linked an issue Jul 11, 2022 that may be closed by this pull request
@DMRobertson
Copy link
Contributor

DMRobertson commented Jul 11, 2022

There are a bunch of unrelated formatting changes here which I'd prefer to be a separate change (if included at all).

We wouldn't be willing to accept this until CPython 3.11 releases, which is expected in October 2022 (per the policy described here #8674 (comment)).

In the meantime, you can build a version of this image yourself as described here.

# DOCKER_BUILDKIT=1 docker build -f docker/Dockerfile --build-arg PYTHON_VERSION=3.10 .

I appreciate that's not as convenient (and won't apply to new releases) but it might give you a way forward for now.

@clokep
Copy link
Member

clokep commented Jul 12, 2022

I've removed this from the review queue per @DMRobertson's comments.

@richvdh
Copy link
Member

richvdh commented Jul 12, 2022

let's close this for now - @Danger89 if you'd like to open a new PR once 3.11 is out, that would be grand!

@richvdh richvdh closed this Jul 12, 2022
@DMRobertson DMRobertson reopened this Nov 3, 2022
@DMRobertson DMRobertson self-assigned this Nov 3, 2022
@DMRobertson
Copy link
Contributor

I reopened this now that 3.11 is released, but it looks like there's a merge conflict here. I'll open a new PR with this change.

@DMRobertson DMRobertson closed this Nov 3, 2022
@melroy89 melroy89 deleted the upgrade_python_3_10 branch January 20, 2023 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Python version in Docker release
4 participants