-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Faster room joins: avoid blocking when pulling events with missing prevs #13355
Faster room joins: avoid blocking when pulling events with missing prevs #13355
Commits on Jul 21, 2022
-
Skip soft fail checks for rooms with partial state
When a room has the partial state flag, we may not have an accurate `m.room.member` event for event senders in the room's current state, and so cannot perform soft fail checks correctly. Skip the soft fail check entirely in this case. As an alternative, we could block until we have full state, but that would prevent us from receiving incoming events over federation, which is undesirable. Signed-off-by: Sean Quah <[email protected]>
Sean Quah committedJul 21, 2022 Configuration menu - View commit details
-
Copy full SHA for ad5d75e - Browse repository at this point
Copy the full SHA ad5d75eView commit details -
Make the
partial_state
parameter tocompute_event_context
stricterPreviously, `partial_state=False` either meant "full state" or "calculate the flag yourself", depending on whether `state_ids_before_event` was provided. Split out the latter meaning into `partial_state=None`. Signed-off-by: Sean Quah <[email protected]>
Sean Quah committedJul 21, 2022 Configuration menu - View commit details
-
Copy full SHA for ff8f6cf - Browse repository at this point
Copy the full SHA ff8f6cfView commit details -
Add
partial_state
parameter to_process_received_pdu
Signed-off-by: Sean Quah <[email protected]>
Sean Quah committedJul 21, 2022 Configuration menu - View commit details
-
Copy full SHA for f7c9a5a - Browse repository at this point
Copy the full SHA f7c9a5aView commit details -
Add
await_full_state
parameter toget_state_groups_ids
, so that i……t can return partial state Signed-off-by: Sean Quah <[email protected]>
Sean Quah committedJul 21, 2022 Configuration menu - View commit details
-
Copy full SHA for bca5a17 - Browse repository at this point
Copy the full SHA bca5a17View commit details -
Allow
_resolve_state_at_missing_prevs
to return partial state, othe……rwise we can block when receiving or backfilling events over federation Signed-off-by: Sean Quah <[email protected]>
Sean Quah committedJul 21, 2022 Configuration menu - View commit details
-
Copy full SHA for 1d48d23 - Browse repository at this point
Copy the full SHA 1d48d23View commit details -
Retry persisting events from federation when we lose the partial stat…
…e race Now that we persist events with partial state, we have to handle `PartialStateConflictError`s, by retrying just once. Signed-off-by: Sean Quah <[email protected]>
Sean Quah committedJul 21, 2022 Configuration menu - View commit details
-
Copy full SHA for 6517210 - Browse repository at this point
Copy the full SHA 6517210View commit details -
Sean Quah committed
Jul 21, 2022 Configuration menu - View commit details
-
Copy full SHA for b879d8c - Browse repository at this point
Copy the full SHA b879d8cView commit details
Commits on Jul 22, 2022
-
Raise an error if we still have partial state on the 2nd try
Sean Quah committedJul 22, 2022 Configuration menu - View commit details
-
Copy full SHA for 7d55d88 - Browse repository at this point
Copy the full SHA 7d55d88View commit details -
Add comment for update_state_for_partial_state_event optimisation
Sean Quah committedJul 22, 2022 Configuration menu - View commit details
-
Copy full SHA for 7870d44 - Browse repository at this point
Copy the full SHA 7870d44View commit details
Commits on Jul 25, 2022
-
Update synapse/handlers/federation_event.py
Co-authored-by: Richard van der Hoff <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 765614f - Browse repository at this point
Copy the full SHA 765614fView commit details